Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

This PR introduces support for generating links from markdown reports to local source files. The links are formatted based on the detected environment (VS Code, GitHub, etc.), allowing direct navigation to specific lines within the IDE.

Closes #745

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 94b4944 with source commit 7b6d7da.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 43 🔴 39 ↓ −3.8
Code coverage 🟡 90 🟢 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟡 87 🟡 87
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 6 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 43 🔴 39 ↓ −3.8
Code coverage Code coverage metrics 🟡 90 🟢 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Eliminate render-blocking resources 🟨 Potential savings of 0 ms 🟥 Potential savings of 130 ms ↑ +∞ %
Lighthouse Speed Index 🟥 6.9 s 🟥 7.8 s ↑ +12.8 %
Lighthouse Largest Contentful Paint 🟥 4.3 s 🟥 4.7 s ↑ +10.1 %
Lighthouse First Meaningful Paint 🟨 3.4 s 🟨 3.6 s ↑ +4.8 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.6 s ↑ +3.9 %
Lighthouse Time to Interactive 🟥 16.2 s 🟥 16.3 s ↑ +0.6 %
Code coverage Branch coverage 🟨 84.9 % 🟨 85.1 % ↑ +0.2 %
Code coverage Function coverage 🟩 92.1 % 🟩 92.3 % ↑ +0.1 %
Code coverage Line coverage 🟩 91.4 % 🟩 91.5 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,799 KiB 🟩 Total size was 1,795 KiB ↓ −0.2 %
Lighthouse Minimizes main-thread work 🟥 21.5 s 🟥 23.7 s ↑ +10.2 %
Lighthouse Total Blocking Time 🟥 8,820 ms 🟥 10,700 ms ↑ +21.3 %
Lighthouse JavaScript execution time 🟥 9.9 s 🟥 11.6 s ↑ +17.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Max Potential First Input Delay 🟥 2,200 ms 🟥 2,070 ms ↓ −6.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.6 %
Lighthouse Initial server response time was short 🟩 Root document took 420 ms 🟩 Root document took 350 ms ↓ −15.2 %
Lighthouse Server Backend Latencies 🟩 100 ms 🟩 100 ms ↑ +2.4 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 60 ms ↓ −3.8 %

494 other audits are unchanged.

@hanna-skryl hanna-skryl force-pushed the add-link-to-local-filesystem-in-reports branch 3 times, most recently from 5b4a23a to a05d996 Compare September 25, 2024 21:32
@hanna-skryl hanna-skryl marked this pull request as ready for review September 25, 2024 21:43
@hanna-skryl hanna-skryl force-pushed the add-link-to-local-filesystem-in-reports branch from a05d996 to c1db243 Compare September 25, 2024 22:05
matejchalk
matejchalk previously approved these changes Oct 1, 2024
vmasek
vmasek previously approved these changes Oct 1, 2024
@hanna-skryl hanna-skryl dismissed stale reviews from vmasek and matejchalk via 690db7f October 1, 2024 15:06
@hanna-skryl hanna-skryl force-pushed the add-link-to-local-filesystem-in-reports branch from 690db7f to e4d97c8 Compare October 1, 2024 15:06
@hanna-skryl hanna-skryl merged commit f98b10a into main Oct 1, 2024
@hanna-skryl hanna-skryl deleted the add-link-to-local-filesystem-in-reports branch October 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues sections should link to local file in your IDE at given commit with highlighted line(s)

5 participants