Skip to content

refactor(cli): adopt build 1 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BioPhoton wants to merge 6 commits into from
Closed

refactor(cli): adopt build 1 #49

BioPhoton wants to merge 6 commits into from

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 16, 2023 •
edited
Loading

This PR includes:

  • fix build to have index.js and bin.js as separate entry points
  • have and e2e test that executes the bundled code over:
    • npx @quality-metrics/cli collect - name before install
    • code-pushup collect - shorthand after install

@BioPhoton BioPhoton added 🆘 help wanted assistance is required 🐛 bug something isn't working 🔬 testing writing tests 🟠 priority: high labels Sep 16, 2023
vmasek
vmasek previously approved these changes Sep 18, 2023
View reviewed changes
@ChristopherPHolder ChristopherPHolder mentioned this pull request Sep 18, 2023
Closed
@BioPhoton BioPhoton closed this Sep 22, 2023
@BioPhoton BioPhoton deleted the polish-cli branch October 9, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmasek vmasek vmasek left review comments

Assignees

No one assigned

Labels

🐛 bug something isn't working 🆘 help wanted assistance is required 🔬 testing writing tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton @vmasek