refactor(utils): separate report sorting logic and use it once for all report outputs #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishaSeredenkoPushBased
added
➕ enhancement
MishaSeredenkoPushBased
requested review from
BioPhoton,
IKatsuba,
Tlacenka,
matejchalk and
vmasek
Tlacenka
suggested changes
Jan 3, 2024
packages/utils/src/lib/__snapshots__/sort-report.integration.test.ts.snap
Show resolved
Hide resolved
BioPhoton
reviewed
Jan 4, 2024
matejchalk
reviewed
Jan 8, 2024
matejchalk
previously approved these changes
Jan 9, 2024
vmasek
previously approved these changes
Jan 9, 2024
Tlacenka
reviewed
Jan 9, 2024
MishaSeredenkoPushBased
dismissed stale reviews from vmasek and matejchalk
via
c7d4172
matejchalk
previously approved these changes
Jan 11, 2024
vmasek
previously approved these changes
Jan 11, 2024
MishaSeredenkoPushBased
dismissed
BioPhoton’s stale review
I dismiss the review to unblock the merge of PR. If there are any things to improve/fix left, it'll be done in a follow-up PR
MishaSeredenkoPushBased
dismissed stale reviews from vmasek, matejchalk, and Tlacenka
via
30995ec
Tlacenka
approved these changes
Jan 12, 2024
matejchalk
approved these changes
Jan 12, 2024
vmasek
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now report will be sorted in the beginning of
persistReport()function, before being passed into any output format.This allows to remove the sorting logic from
reportToMdandreportToStdout.Closes #352