Skip to content

Conversation

@MishaSeredenkoPushBased
Copy link
Contributor

Added sorting of audit issues for report.md:

  • by severity (errors first),
  • by source file (alphabetical),
  • by start line (ascending).

Closes #313

matejchalk
matejchalk previously approved these changes Dec 5, 2023
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments regarding tests. Over all I like the pr a lot. Will make it easier to read the report.

Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MishaSeredenkoPushBased MishaSeredenkoPushBased merged commit 1264c7d into main Dec 11, 2023
@MishaSeredenkoPushBased MishaSeredenkoPushBased deleted the sort-audit-issues-report-md branch December 11, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug something isn't working 🔬 testing writing tests 🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorting of issues is not given report.md is off

5 participants