feat(nx-plugin): add configuration generator #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioPhoton
reviewed
Nov 20, 2023
Collaborator
BioPhoton
left a comment
BioPhoton
left a comment
There was a problem hiding this comment.
Left small comments regarding naming
packages/nx-plugin/src/generators/add-to-project/generator.unit.test.ts
Outdated
Show resolved
Hide resolved
IKatsuba
force-pushed
the
add-to-project
branch
from
3855a47 to
4996aea
Compare
IKatsuba
changed the title
IKatsuba
requested review from
BioPhoton,
MishaSeredenkoPushBased,
Tlacenka and
matejchalk
matejchalk
reviewed
Nov 22, 2023
packages/nx-plugin/src/generators/configuration/files/code-pushup.config.js.template
Outdated
Show resolved
Hide resolved
packages/nx-plugin/src/generators/configuration/generator.unit.test.ts
Outdated
Show resolved
Hide resolved
IKatsuba
force-pushed
the
add-to-project
branch
from
4996aea to
ed4f116
Compare
matejchalk
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #61