Skip to content

Code spike for managed stripe accounts#849

Merged
joshsmith merged 1 commit intodevelopfrom
spike-for-managed-accounts
Dec 14, 2016
Merged

Code spike for managed stripe accounts#849
joshsmith merged 1 commit intodevelopfrom
spike-for-managed-accounts

Conversation

@begedin
Copy link
Contributor

@begedin begedin commented Dec 9, 2016

What's in this PR?

This is a code spike for the switch to managed stripe accounts

What we have for now:

The process

  1. Instead of a stripe connect button, we get a form to specify business information.
  2. Submitting a form attempts to save a stripe-connect-account record to the server
  3. Server, if stripity stripe uses the latest commit from Add Account.create beam-community/stripity-stripe#153, will create a connect account.

Related infrastructure, but not hooked into the process yet.

  • The "bank account information" form is now also rendered and the action, with the parameters,
    is passed all the way to the controller, where it does nothing as of yet.
  • All the tests have been fixed.
  • A bunch of todos was added indicating how we should continue
  • Email is bound from the current user
  • I tried to make this as flat and self-contained as possible, so we can merge and split out individual tasks as much as we can.

References

<div class="input-group">
<label>
Birthday
{{pikaday-input format="MM/DD/YYYY" onSelection=(action 'setDob') value=dob}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshsmith
Copy link
Contributor

I might recommend not doing much at the controller level here and instead just write out the basic form fields per #853. Then we can slowly take that work and use it to break out into separate components in separate PRs, then actual integrated logic after that.

What do you think @begedin?

@begedin begedin force-pushed the spike-for-managed-accounts branch from 6d7aa12 to dc68beb Compare December 12, 2016 10:48
@begedin
Copy link
Contributor Author

begedin commented Dec 12, 2016

@joshsmith I got this as far as I could in the time I had. I tried to make it as easy to take over as possible. I believe it can be merged mostly as is and then the work that follows can be performed in smaller chunks.

@rileytaylor
Copy link
Contributor

@begedin @joshsmith Merging and creating some issues for smaller chunks would be fantastic, I'd definitely be able to take a small chunk with the time I have right now.

Routing looks good, basic form setup checks out with the plan. I'm a fan of that pikaday component for date-picking.

@joshsmith
Copy link
Contributor

Yeah as soon as I'm back from the dentist I will break it down.

@joshsmith joshsmith force-pushed the spike-for-managed-accounts branch 2 times, most recently from bf18835 to e224e79 Compare December 14, 2016 07:22
@joshsmith joshsmith force-pushed the spike-for-managed-accounts branch from e224e79 to eee0b75 Compare December 14, 2016 07:29
@joshsmith joshsmith merged commit 512e30e into develop Dec 14, 2016
@joshsmith joshsmith deleted the spike-for-managed-accounts branch December 14, 2016 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants