Merged
Conversation
joshsmith
approved these changes
Jan 15, 2017
Contributor
joshsmith
left a comment
joshsmith
left a comment
There was a problem hiding this comment.
Looks good, just some minor alpha ordering suggestions you can change when you rebase.
web/models/stripe_event.ex
Outdated
| |> cast(params, [:endpoint, :id_from_stripe, :type, :user_id]) | ||
| |> validate_required([:endpoint, :id_from_stripe, :type]) | ||
| |> cast(params, [:endpoint, :id_from_stripe, :type, :user_id, :object_id, :object_type]) | ||
| |> validate_required([:endpoint, :id_from_stripe, :type, :object_id, :object_type]) |
test/support/factories.ex
Outdated
| type: "test.type" | ||
| type: "test.type", | ||
| object_id: "cus_123", | ||
| object_type: "customer" |
| "id_from_stripe" => "evt_123", | ||
| "type" => "some.event", | ||
| "user_id" => "act_123", | ||
| "endpoint" => "connect" |
joshsmith
added
ready to merge
needs submitter response
and removed
needs code review
labels
begedin
force-pushed
the
617-track-event-object-ids
branch
from
e011e1b to
aa11f2c
Compare
begedin
force-pushed
the
617-track-event-object-ids
branch
from
aa11f2c to
9bbe954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added everything needed to store object ids and types with an event record.
This means that when a webhook event is stored locally, we also store information about the id and type of the object contained in the event.
References
Fixes #617