Merged
Conversation
joshsmith
force-pushed
the
537-add-invoices
branch
from
416d343 to
875309b
Compare
Contributor
|
This is a little janky. I would prefer better ways of handling all the related resources, but I couldn't think of any. It works, though. We also should probably write a better set of property tracking for invoices. |
begedin
commented
Jan 5, 2017
Contributor
Author
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
Generally looks good, just confused about the :amount field.
Also, I can't approve or request changes, since I'm the pull request author 👍
| # Format is {:local_key, [:nesting, :of, :stripe, :keys]} | ||
| @stripe_mapping [ | ||
| {:id_from_stripe, [:id]}, | ||
| {:amount, [:amount]}, |
Contributor
Author
There was a problem hiding this comment.
I'm not seeing :amount in the API docs? Where do we get it from?
Contributor
There was a problem hiding this comment.
You're right. Idk how I got it.
Contributor
There was a problem hiding this comment.
Need to change in stripity.
| def create(invoice_id_from_stripe, customer_id_from_stripe) do | ||
| with account_id <- get_connect_account(customer_id_from_stripe), | ||
| {:ok, %Stripe.Invoice{} = invoice} <- @api.Invoice.retrieve(invoice_id_from_stripe, connect_account: account_id), | ||
| {:ok, params} <- StripeInvoiceAdapter.to_params(invoice) |
Contributor
Author
There was a problem hiding this comment.
Some weird indentation issue here.
joshsmith
force-pushed
the
537-add-invoices
branch
from
d5f477d to
d84edeb
Compare
joshsmith
approved these changes
Jan 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Work in progress for #537
TODO:
References
Fixes #537