Conversation
|
This change is |
taroface
left a comment
taroface
left a comment
There was a problem hiding this comment.
Reviewed 50 of 50 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jseldess and @lnhsingh)
_includes/v1.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
missing "the" (not part of your update, I know)!
_includes/v19.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
Same as above.
_includes/v19.2/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
Same as above.
_includes/v2.0/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
Same as above.
_includes/v2.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
Same as above.
_includes/v20.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
Same as above.
_includes/v20.2/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
To see this in action: 1. Terminate one of CockroachDB nodes:
Same as above.
_includes/v20.2/prod-deployment/node-shutdown.md, line 1 at r1 (raw file):
- If the node was started with a process manager like [systemd](https://www.freedesktop.org/wiki/Software/systemd/), terminate the node using the process manager. The process manager should be configured to send `SIGTERM` and then, after about 1 minute, `SIGKILL`.
I think this is unfortunately now out of sync with my changes in #7542. That change draws a distinction between using SIGTERM to "gracefully stop" and SIGKILL to forcefully "terminate" a node. I'll leave the exact wording choice to your discretion based on the feedback in #7767.
lnhsingh
left a comment
lnhsingh
left a comment
There was a problem hiding this comment.
Reviewable status:
_includes/v1.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
missing "the" (not part of your update, I know)!
Done.
_includes/v19.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same as above.
Done.
_includes/v19.2/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same as above.
Done.
_includes/v2.0/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same as above.
Done.
_includes/v2.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same as above.
Done.
_includes/v20.1/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same as above.
Done.
_includes/v20.2/orchestration/kubernetes-simulate-failure.md, line 5 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
Same as above.
Done.
_includes/v20.2/prod-deployment/node-shutdown.md, line 1 at r1 (raw file):
Previously, taroface (Ryan Kuo) wrote…
I think this is unfortunately now out of sync with my changes in #7542. That change draws a distinction between using SIGTERM to "gracefully stop" and SIGKILL to forcefully "terminate" a node. I'll leave the exact wording choice to your discretion based on the feedback in #7767.
Thanks for pointing this out! I'll resolve merge conflicts -- your updates look to be in line w the terminology changes already!
jseldess
left a comment
jseldess
left a comment
There was a problem hiding this comment.
Reviewable status:
4 participants
The term "kill" was recently replaced with "stop". After discussing, it was decided that some of these instances actually need to be "terminate". See #7767 for an explanation of the nuances.
Closes #7767.