ui: simplify statement details route to remove implicitTxn param #159558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
kyle-a-wong
force-pushed
the
implicit_txn_url
branch
from
39822ea to
6acebfa
Compare
Previously, statement details routes included the `implicitTxn` parameter
in the URL path (e.g., `/statement/true/:statementId`). This was
unnecessary complexity since the implicit transaction status can be
retrieved from the statement details themselves.
This change simplifies the statement details routing by:
- Removing all redirect routes that used `RedirectToStatementDetails`
- Updating `StatementLinkTarget` to generate simpler URLs without
`implicitTxn`
- Removing `implicitTxn` from `StatementLinkProps` and related types
- Updating all link generators across the codebase to use the new
simpler URL format `/statement/:statementId`
- Removing the now-unused `implicitTxnAttr` constant
- Deleting the `RedirectToStatementDetails` component
Epic: None
Release note (ui change): Simplified statement details page URLs
from `/statement/{implicitTxn}/{statementId}` to
`/statement/{statementId}`. Existing bookmarks using the old URL
format will no longer work.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
kyle-a-wong
force-pushed
the
implicit_txn_url
branch
from
6acebfa to
646e6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, statement details routes included the
implicitTxnparameter in the URL path (e.g.,/statement/true/:statementId). This was unnecessary complexity since the implicit transaction status can be retrieved from the statement details themselves.This change simplifies the statement details routing by:
RedirectToStatementDetailsStatementLinkTargetto generate simpler URLs withoutimplicitTxnimplicitTxnfromStatementLinkPropsand related types/statement/:statementIdimplicitTxnAttrconstantRedirectToStatementDetailscomponentEpic: None
Release note (ui change): Simplified statement details page URLs from
/statement/{implicitTxn}/{statementId}to/statement/{statementId}. Existing bookmarks using the old URL format will no longer work.🤖 Generated with Claude Code