Draft
Conversation
fwiesel
force-pushed
the
cortex-aggregates
branch
from
bd74050 to
1d5581b
Compare
Almost the same logic code was used in the aggregates and the onboarding controller, with the variation that the onboarding controller was also creating the zone aggregate, and the aggregates controller kept aggregates modified outside of the controller untouched. Let's drop that functionality and expect that all aggregates are somehow created externally (i.e. by another controller), and then we can combine that logic in one function, that also can be called by the offboarding controller. Cortex wants to rely on the aggregates in the status, so we keeping extra aggregates is unsupported either way.
Three controllers were calling ApplyAggregates, but only one was maintaining the status. Unify that, so we always an accurate reflection on the aggregates there.
This is a preparation to keep track of the aggregate ids. The old functions are unused so let's remove them.
For Cortex, we want the uuids in addition to the names, so keep track of them in the status.
fwiesel
force-pushed
the
cortex-aggregates
branch
from
1d5581b to
2042fca
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.