287 clowder2 test extractor #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddey2
changed the base branch from
master
to
50-clowder20-submit-file-to-extractor
upload file for v2 did not properly return the id of the uploaded file. added a text file (looks like the original was not checked in) gave it a more descriptive name.
files.get_summary gets the equivalent of the file info in v2
Contributor
|
You can use this new method it should get the file info:
|
tcnichol
approved these changes
Feb 3, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Marking approved.
Tested and all parts of testing for files and datasets worked. The method for getting file summary is added on this pull request as well since it was needed for the tests.
Build errors are still there, but the rest is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.