Skip to content

Conversation

@longshuicy
Copy link
Member

Implemented a footer.

  • When there is long page, this footer will sink to the bottom
  • When there is a short page, this footer stick to the bottom of the view part
  • When side bar opens and collapses, this footer shrink/expand accordingly

To test, please try various pages and see how it looks.

Some screenshots.
Education skin ever baby white page later
Pasted Graphic 84
image

@longshuicy longshuicy requested review from ddey2, lmarini and tcnichol April 9, 2024 14:49
@longshuicy longshuicy linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. There is no footer for the public page. Is that intended?

@lmarini lmarini requested a review from ddey2 April 12, 2024 14:42
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Made minor modifications to links and text.

@longshuicy
Copy link
Member Author

It looks good. There is no footer for the public page. Is that intended?

sorry just added that to public page too

Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@longshuicy longshuicy merged commit 57ef2e0 into main Apr 12, 2024
@longshuicy longshuicy deleted the 961-add-footer-for-frontend-pages branch April 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add footer for frontend pages

4 participants