Skip to content

Conversation

@longshuicy
Copy link
Member

Might include more UI screenshot once the definition part is ready

@longshuicy longshuicy requested a review from arunapa September 22, 2022 20:03
@longshuicy longshuicy linked an issue Sep 22, 2022 that may be closed by this pull request
"name" : "Unit",
"description" : "Unit",
"context" : {
"doi" : "https://schema.org/QuantitativeValue"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "unit" instead of doi

@lmarini
Copy link
Member

lmarini commented Oct 24, 2022

can we merge this?

@longshuicy longshuicy marked this pull request as ready for review October 24, 2022 20:20
@longshuicy longshuicy requested a review from max-zilla as a code owner October 24, 2022 20:20
@longshuicy
Copy link
Member Author

Sure let's merge this

@longshuicy longshuicy closed this Oct 24, 2022
@longshuicy longshuicy reopened this Oct 24, 2022
@longshuicy
Copy link
Member Author

can we merge this?

Yes you can merge this

@lmarini lmarini merged commit 79afcab into main Oct 24, 2022
@lmarini lmarini deleted the 95-conclude-metadata-design-documentation branch October 24, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conclude metadata design documentation

4 participants