Fix/pytest keycloak timeout #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed platform for docker compose elasticsearch services as it was not working with older macs.
Don't mount keycloak data directory and fix volume for Elasticsearch and Keycloak.
# Conflicts: # docker-compose.dev.yml
the pytest would pass.
Removed requirements.txt. We should be using Pipfile.
Member
Author
|
@ddey2 the elasticsearch test claims it passed, but in the shell there is an error printed out. Not sure why.
|
Member
|
@lmarini I will checkout this branch and try this out. I will keep you posted. |
max-zilla
approved these changes
Sep 26, 2022
Contributor
max-zilla
left a comment
max-zilla
left a comment
There was a problem hiding this comment.
Verified this fixed the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change keycloak back to not mounting the local data directory use the postgres services. The env variables changed with the new version of Keycloak and it wasn't connecting to it at all. It was default to H2 database. @tcnichol the change you made fixed it because it was then storing the H2 files in a volume, but it was still ignoring the posgres database. I am not sure why this fixed the pytest build on the server.