Skip to content

Conversation

@longshuicy
Copy link
Member

This fix the bug that "Analysis" tab is visible but not clickable.
The tricky part is "tab" is associate with indexes as id, cannot be dynamically show/hide at the dom tree level (?). Instead, I can use the css "display:none" to hide and show.

To test:

  1. create 2 users
  2. user A create a dataset and share with user B as "viewer"
  3. user b shouldn't see analysis/ sharing tab on dataset as well as on files.

@longshuicy longshuicy requested review from lmarini and tcnichol March 26, 2024 04:19
@lmarini lmarini merged commit 9e5fcce into release/v2.0.0-beta2 Mar 26, 2024
@lmarini lmarini deleted the fix-analysis-tab branch March 26, 2024 13:56
@ddey2 ddey2 self-requested a review March 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants