Skip to content

Conversation

@tcnichol
Copy link
Contributor

This adds 'my datasets' so that a user can see just their datasets on another tab, separate from the shared, authenticated and public datasets.

@tcnichol tcnichol requested a review from longshuicy as a code owner March 11, 2024 21:10
@tcnichol tcnichol linked an issue Mar 11, 2024 that may be closed by this pull request
@tcnichol tcnichol requested review from ddey2 and lmarini March 11, 2024 21:11
@tcnichol
Copy link
Contributor Author

all datasets
listdatasets

and 'my datasets' tab

mydatasets

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing is SuperAdmin doesn't immediately reflected on the MyDataset page. If you refresh the page then you see it. Need to add superAdmin in the useEffect hook.

@tcnichol tcnichol requested a review from max-zilla as a code owner March 12, 2024 17:11
@tcnichol
Copy link
Contributor Author

I believe I have fixed some pagination issues with myDatasets. I needed some extra methods so that pagination is separated for each tab.

@lmarini lmarini requested a review from longshuicy March 28, 2024 14:09
Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work

@lmarini lmarini requested a review from ddey2 April 18, 2024 14:48
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I flip to My Datasets and then go back to all datasets I only see my datasets.

@tcnichol
Copy link
Contributor Author

If I flip to My Datasets and then go back to all datasets I only see my datasets.

When the tab is changed, I wasn't changing 'mine' after the tab was clicked back. This should be fixed now.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination is still not quite right. To reproduce:

  1. on the all dataset page, flip a few pages
  2. switch to "my" tab
  3. the previous button becomes clickable even though I just have one page. Upon clicking the flip button, I get an empty page
image image

@tcnichol
Copy link
Contributor Author

Pagination is still not quite right. To reproduce:

  1. on the all dataset page, flip a few pages
  2. switch to "my" tab
  3. the previous button becomes clickable even though I just have one page. Upon clicking the flip button, I get an empty page

image image

I think this is fixed now. I can go to a later page, switch to 'my datasets' and then I'll be back at 1, with only 1 page showing.

@longshuicy
Copy link
Member

Pagination is still not quite right. To reproduce:

  1. on the all dataset page, flip a few pages
  2. switch to "my" tab
  3. the previous button becomes clickable even though I just have one page. Upon clicking the flip button, I get an empty page

image image

I think this is fixed now. I can go to a later page, switch to 'my datasets' and then I'll be back at 1, with only 1 page showing.

But somehow the previous button is still clickable and I'm not sure it's quite on 1
image

@lmarini
Copy link
Member

lmarini commented Jun 3, 2024

Pagination is still not quite right. To reproduce:

  1. on the all dataset page, flip a few pages
  2. switch to "my" tab
  3. the previous button becomes clickable even though I just have one page. Upon clicking the flip button, I get an empty page

image image

I think this is fixed now. I can go to a later page, switch to 'my datasets' and then I'll be back at 1, with only 1 page showing.

But somehow the previous button is still clickable and I'm not sure it's quite on 1 image

@tcnichol is this fixed now? Thanks.

@tcnichol
Copy link
Contributor Author

tcnichol commented Jun 3, 2024

Pagination is still not quite right. To reproduce:

  1. on the all dataset page, flip a few pages
  2. switch to "my" tab
  3. the previous button becomes clickable even though I just have one page. Upon clicking the flip button, I get an empty page

image image

I think this is fixed now. I can go to a later page, switch to 'my datasets' and then I'll be back at 1, with only 1 page showing.

But somehow the previous button is still clickable and I'm not sure it's quite on 1 image

@tcnichol is this fixed now? Thanks.

I have checked and now when you click 'my datasets' the 'previous' button is no longer active.

@longshuicy
Copy link
Member

The above mentioned pagination issue has resolved;
However I discovered another one:

  1. If you have many pages on "My dataset" tab
  2. Flip to a later page
  3. Switch back to "Dataset" tab
  4. It will be flipped to that page. Maybe we would like to start from the first page to be consistent?
image

@tcnichol
Copy link
Contributor Author

tcnichol commented Jun 3, 2024

The above mentioned pagination issue has resolved; However I discovered another one:

  1. If you have many pages on "My dataset" tab
  2. Flip to a later page
  3. Switch back to "Dataset" tab
  4. It will be flipped to that page. Maybe we would like to start from the first page to be consistent?
image

I see that I forgot to change page when tab switching to 'datasets.' Now it should behave the same as switching to my datasets - you will go back to the first page.

@lmarini lmarini requested review from lmarini and longshuicy June 6, 2024 14:48
@longshuicy longshuicy merged commit eaeec68 into main Jun 7, 2024
@longshuicy longshuicy deleted the 954-my-datasets branch June 7, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

My datasets

5 participants