836 public search option

[tcnichol]

This pull request will enable a search of public data for non-logged in users.

It also fixes a problem. When a logged in user would search, public and authenticated matches were not being shown. In the query 'public' and 'authenticated' had to be in all lowercase. Additionally, not all files were having their status updated when the dataset changed. This is also fixed.

To test, create datasets. Make sure some are public and authenticated.

If no user is logged in, public datasets and files should show up in search results.

If a user is logged in, public and authenticated datasets and files should show up in search results, along with their own items or datasets explicitly shared.

Changing the status of a dataset should be reflected in search results.

[ddey2]

@tcnichol I can see the public datasets in the dropdown list for public search. But when I click enter or click on any of the dataset form the dropdown list, it doesn't take me to the search result page or the dataset page itself.

[tcnichol]

@tcnichol I can see the public datasets in the dropdown list for public search. But when I click enter or click on any of the dataset form the dropdown list, it doesn't take me to the search result page or the dataset page itself.

I think I have fixed this. I noticed that in the search results the links were not for public_datasets or public_files, they were the same as for logged in search. I added a PublicSearchResult component which should fix these issues.

[longshuicy]

Public search works.
Regular Search now also includes public information.
One mis-match i noticed is:

• Public search found an item
• Click link of that item leads to the wrong url
  e.g.

http://localhost:3000/public/datasets/65e0cd7d97540f9ae8425eba
vs
http://localhost:3000/public_datasets/65e0cd7d97540f9ae8425eba

[tcnichol]

@longshuicy

I checked and the search result links should be fixed for public search now, for both files and datasets.

[ddey2]

Rest looks good to me. Once you import SearchDatasetIcon, public search works.

[ddey2]

@tcnichol Clicking on the link after the search doesn't work. Clicking on the dataset takes you to the main page.

[ddey2]

left comment

[tcnichol]

@ddey2 I noticed that there was an inconsistency in the routes for public_datasets. Some spots had public/datasets instead. Went through and I think I fixed that.

Though now the link to the public search is broken at the top of the Public page, working on that.

[ddey2]

Looks good.

[longshuicy]

Public search seems to be able to match dataset, not files though. Might be your clause is specifically matching dataset status. Not sure how to get around, but at least I would change the label Search for Datasets and Files

[longshuicy]

@tcnichol any chance you have addressed public files not searchable issue? If it is challenging, could you create another issue to address that separately? The rest of this PR looks good.

[tcnichol]

@tcnichol any chance you have addressed public files not searchable issue? If it is challenging, could you create another issue to address that separately? The rest of this PR looks good.

Let me check. I think it should be fixed because the problem was that the fields for public or authenticated were null for files in elasticsearch, but that should be fixed now. I'll make sure it is working.

[lmarini]

@tcnichol any chance you have addressed public files not searchable issue? If it is challenging, could you create another issue to address that separately? The rest of this PR looks good.

Let me check. I think it should be fixed because the problem was that the fields for public or authenticated were null for files in elasticsearch, but that should be fixed now. I'll make sure it is working.

@tcnichol is this fixed now? Thanks.

[longshuicy]

After drop volume and restart, elasticsearch is indexing properly and I can search for files. Approved.