-
Notifications
You must be signed in to change notification settings - Fork 6
implemented standard list of licenses #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix pytest failure fix pytest failure
|
I'm getting an error when I try to add a custom license. Here is the error I'm seeing
|
tcnichol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Everything works, including custom license which I can edit after adding.
|
@tcnichol I added the logo, Could you please retest it? |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional things I noticed:
- For holders, are we freely allowing anyone (username? full name? email?) to be the holder or they need to be clowder user? @lmarini
- After creating a custom licnece, then I went in edit for the first time (without changing the date time), i got above error.
- if i change anything on the datetime, it passed and it never happened again
@longshuicy I am not able to reproduce this one. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now. Thank you!
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry 2 more things I just noticed. But feel free to address in another issue:
- The selecting licence part seems to be optional. Is that intended deisgn? @lmarini
- if nothing is set, could we have some default text saying "no licence?". Right now it's showing a broken link
Sorry @longshuicy @ddey2 I clicked merge too quickly! We can definitively do this on a separate PR. I think we shouldn't let them leave license blank. |
No worries. I meant to open new issue and will do :-) |




PFA screenshots for reference.



