Skip to content

extractors removed from public, front end error fixed. #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
longshuicy merged 1 commit into from
Feb 5, 2024
Merged

extractors removed from public, front end error fixed. #909

longshuicy merged 1 commit into from
Feb 5, 2024

Conversation

@tcnichol
Copy link
Contributor

@tcnichol tcnichol commented Feb 2, 2024 •
edited
Loading

This pull request does 2 things. It is linked to 2 issues.

  1. It removed Extractors/Listeners from the Public page.
  2. I was seeing a backend error when I loaded the public page and noticed that listDatasets (the listDatasets that requires a user) was being called. There's no reason to do that in public and it returns an error, so I removed that.

@tcnichol
extractors removed
04c8a51 
also fixed an error that was popping up. for some reason listDatasets was being called on the Public component.
@tcnichol tcnichol requested a review from longshuicy as a code owner February 2, 2024 20:37
@tcnichol tcnichol linked an issue Feb 2, 2024 that may be closed by this pull request
Don't list extractors on the public explore page #906
Closed
@tcnichol tcnichol requested a review from ddey2 February 2, 2024 20:37
@tcnichol tcnichol linked an issue Feb 2, 2024 that may be closed by this pull request
remove listDatasets from public page. #910
Closed
@longshuicy longshuicy merged commit a9f1086 into main Feb 5, 2024
@longshuicy longshuicy deleted the 906-dont-list-extractors-on-the-public-explore-page branch February 5, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longshuicy longshuicy longshuicy approved these changes

@ddey2 ddey2 Awaiting requested review from ddey2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove listDatasets from public page. Don't list extractors on the public explore page

3 participants

@tcnichol @longshuicy