892 latest main branch is not building the frontend image correct #893
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I built the docker image with and then used that image in the docker-compose file for frontend and it is now working. and i am seeing all the bundles inside /usr/share/nginx/html |
tcnichol
approved these changes
Jan 22, 2024
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Build the image, had docker-compose point to that image, and checked for bundles. Everything is working as it should now.
Member
Author
Yes I updated my description of the PR. I made some typo there. Thank you for sharing how to correctly build the image. |
ddey2
approved these changes
Jan 22, 2024
longshuicy
deleted the
892-latest-main-branch-is-not-building-the-frontend-image-correct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typo is causing the build failure.
To test:
cd frontendand rundocker build -t clowder/clowder2-frontend:test-build .docker-compose.ymlto this imageimage: "clowder/clowder2-frontend:test-build"Some helpful command e.g. get into the built image to check nginx folder
docker run -it clowder/clowder2-frontend:test-build /bin/shYou should see all the bundles there