Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Jan 12, 2024

Now, user select dataset/file while creating a metadata definition to indicate if this metadata is required for creating new dataset/file.
Screenshot 2024-01-12 at 4 51 27 PM

Also, removed the icon button in "Metadata Definition" button

@ddey2 ddey2 linked an issue Jan 12, 2024 that may be closed by this pull request
@ddey2 ddey2 requested review from lmarini, longshuicy and tcnichol and removed request for longshuicy and max-zilla January 12, 2024 22:51
@longshuicy
Copy link
Member

Could you ran codegen and lint? I saw 2 failed github action.

@ddey2
Copy link
Member Author

ddey2 commented Jan 19, 2024

Modified UI to show only required metadata now. So, if you have created a metadata definition which is required for datasets, it will show up when you try to create a new dataset.
Screenshot 2024-01-19 at 2 59 33 PM
Screenshot 2024-01-19 at 2 59 46 PM

@lmarini lmarini requested a review from longshuicy January 23, 2024 14:50
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well approve.

@longshuicy longshuicy linked an issue Jan 24, 2024 that may be closed by this pull request
@lmarini lmarini merged commit cf3877e into main Jan 25, 2024
@lmarini lmarini deleted the 771-require-metadata-fields-by-files-or-datasets branch January 25, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove info icon from "New Metadata Definition" button Require metadata fields by files or datasets

4 participants