-
Notifications
You must be signed in to change notification settings - Fork 6
842 UI component for assign admin #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. I still had to drop datasets and metadata definition to make it work with the admin field. I also added a line to delete-data.sh to drop metadata definition.
Should we move the "Manage Data" link from the personal menu in the top right to the tray menu on the left?
Ah i see that's what's missing in the drop script. Do mean the "Manage Users" link? I can certainly do that :-) |
|
|
Tested this one and everything looks good. Users cannot revoke their own status. |
tcnichol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this one and everything seems to work fine. Checked that users could not remove own admin status.

This PR:
To test:
scripts/develop/populate_fake_data/populate_fake_data.py. Change number of users if needed