Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Nov 17, 2023

  1. show if an user is admin or not on UI
  2. Enable admin user to view everything if only the admin_mode is turned on

@ddey2 ddey2 requested review from lmarini and tcnichol November 17, 2023 16:31
@ddey2 ddey2 linked an issue Nov 17, 2023 that may be closed by this pull request
@ddey2 ddey2 marked this pull request as draft November 17, 2023 16:31
@ddey2 ddey2 changed the base branch from main to 817-add-admin-dependency November 17, 2023 16:32
@tcnichol
Copy link
Contributor

I pushed a small fix in authorizationservice.

Testing it, I can see all users datasets and files with admin mode activated, and when turned off we revert to what it was before.

@ddey2 ddey2 marked this pull request as ready for review November 22, 2023 19:57
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the last few commits all the issues are resolved and this works. Marking approved.

@longshuicy
Copy link
Member

A few things I noticed:

  • Once page refreshed, it automatically switch to non-admin mode. Maybe because it's only stored in the redux. Do we want to registered that enable admin mode state to the backend?
  • This will also mitigate all the additional parameter needed for every single route
  • Search page with admin doesn't work. I can't see other person's resource even though i'm admin
  • Lastly, nitpicking... could you add a little bit more vertical padding of the "Admin Mode" in the dropdown to match other items?
image

Base automatically changed from 817-add-admin-dependency to main December 1, 2023 15:28
@longshuicy longshuicy closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Superadmin mode.

4 participants