485 public datasets visible when not logged in #832
Conversation
download is available, though button will not work on page when added
will probably need to refactor content from Dataset so that they can both import the same things, with 'publicView' as boolean that will determine what is shown
details not working
this should make having a public dataset easier
|
How to test this pull request. Note - the new 'default' page is now the public page. Login and register are in the upper right hand corner. Create at least 2 Users. Using User1, create datasets and upload files. Then mark at least one dataset 'public' by changing the status from 'private' to 'public.' If you log out as that user, then you will see the public datasets. Other users will also see them when logged in. So if User1 made a dataset public, User2 will see it when logged in. |
|
New instructions for testing. If you start up a clowder instance, run the populate fake data script. It will generate some public datasets and they should be visible when you are not logged in. The new default page is the public page, with login and register in the upper right corner. |
There was a problem hiding this comment.
Could we remove those dividers?
Download version history doesn't work. i think the url is wrong, instead of public/files you should use public_files in the URL
Download dataset button doesn't work. It's still pointing to the private endpoint.
Download dataset button inside the dataset page doesn't work either. Not sure why
backend/app/main.py
Outdated
| dependencies=[Depends(get_current_username)], | ||
| ) | ||
| api_router.include_router( | ||
| elasticsearch.router, |
There was a problem hiding this comment.
@tcnichol did you have a chance to take a look if this route should use the public_elasticsearch.py instead?
dataset download fixed download file and file version fixed public elasticsearch added to router
|
@longshuicy i removed the divider and addressed your comments. |
public dataset card allows dataset download when public
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
All the suggestions are resolved now. Approve.
But could you fix the black linting before merging?
black formatting
|
I'm not sure what is going wrong. I am running
and i see that it's changing populate_fake_data.py but when I go to commit it shows nothing. Same with the backend/app I deleted my clowder2 local and cloned again and built new environment, now black seems to be formatting right. |
ready for review now