804 move searchbox to top for metadata definition and group page #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-zilla
approved these changes
Nov 6, 2023
ddey2
requested changes
Nov 6, 2023
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
UI looks good.
However the search is not working. I tried to search metadata definition. Lmk if that is not related to this PR. I ll create a separate bug.
ddey2
approved these changes
Nov 6, 2023
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
I think it's bug. I have create a separate issue for that. Approving
longshuicy
deleted the
804-move-searchbox-to-top-for-metadata-definition-and-group-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrapped the search widget with title and prompt to a generic component.
Move it up to the top and clean up the groups and metadata definition page a little bit.