Basic implementation of admin in user collection in mongodb #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
black formatting adding codegen file removing redundant print statement fixing pytest failure fixing pytest failure ran black
ddey2
force-pushed
the
803-basic-implementation-for-admin
branch
from
a3ff621 to
795c825
Compare
tcnichol
approved these changes
Nov 1, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
This one works, checked and I can make other users admin.
max-zilla
reviewed
Nov 6, 2023
max-zilla
approved these changes
Nov 6, 2023
Contributor
max-zilla
left a comment
max-zilla
left a comment
There was a problem hiding this comment.
PR looks good aside from the note to use Mongo's built-in counting for efficiency.
max-zilla
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test
To test that one user can set another as admin, please use POSTMAN. Refer to the attached ss for details.
