Skip to content

Conversation

@MBcode
Copy link
Contributor

@MBcode MBcode commented Sep 2, 2022

While getting started my 1st user did not have a first/last name, so login was blocked,
So I changed the access of userinfo to a .get with a default of " "
Which allowed login, for when you don't have those (I've assumed) not required fields

I also added a changelog for the backend, because I didn't see one yet

ps=I plan to continue to use this branch, to try out at a root resource class,
w/the ability to add metadata, so we don't have to replicate those methods

@MBcode MBcode requested review from lmarini and longshuicy September 2, 2022 19:08
@MBcode MBcode requested a review from max-zilla as a code owner September 15, 2022 17:47
@MBcode
Copy link
Contributor Author

MBcode commented Sep 15, 2022

change readme to instructions that allowed seeing altered index
So with 2 changed Readme lines, could add the 1 new index line
and see the pycharm.md files I had added.
Seemed small but, I should have had in another branch, sorry abou that

## [0.0.1] - 2021-11-10

### Added
- Allow for missing first/last names in userinfo, defaulting to " "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we doing the changelog now?

@lmarini lmarini merged commit bafe9d0 into main Sep 21, 2022
@lmarini lmarini deleted the metadata4moreResourceTypes branch September 21, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants