Dockerize heartbeat #76
Conversation
it now works
2.4.1 becomes 2.41 etc
some extractors use a.b.c etc to denote version
version parse replaced the float comparison better logging - log if new extractor registered or updated
| pipenv = "*" | ||
| install = "*" | ||
| rocrate = "*" | ||
| packaging= "*" |
There was a problem hiding this comment.
Are these required? For example black should not be included in the build, just in [dev-packages. What are packaging and app?
There was a problem hiding this comment.
I don't think these are used, and am not sure how they got in. Removing them now.
There was a problem hiding this comment.
I added the packaging module since it parses versions - I am adding it back in since I do use it.
| @@ -0,0 +1,74 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Can you add some comments throughout the file. At a minimum a doc string for each function, but also about some of the specific of some of the more complex code blocks. We need to start being more strict about requiring comments. Thanks!
There was a problem hiding this comment.
Ill get these added this afternoon.
There was a problem hiding this comment.
Did you get a chance to work on this?
lmarini
left a comment
lmarini
left a comment
There was a problem hiding this comment.
Getting a runtime error when running the container after building it with docker compose up --build.
2023-01-12 11:19:08 File "/code/app/heartbeat_listener_sync.py", line 7, in <module>
2023-01-12 11:19:08 from app.config import settings
2023-01-12 11:19:08 ModuleNotFoundError: No module named 'app.config'```
changing imports back in heartbeat listener adding pythonpath to dockerfile for heartbeat
|
I fixed the runtime error. Added PYTHONPATH to the heartbeat.Dockerfile and now the imports are working. There seem to be new build errors now, looks like when doing the pytest it can't connect to keycloak. |
I'm leaving this one as draft. I have moved the extractor heartbeat stuff to its own folder alongside backend and frontend, with the idea that it will run as a separate service.
This means that inside of that folder I am copying some of the code from backend. I have also added this in the docker-compose.dev.yml file, but so far it does not appear that it connects to rabbitmq from inside there. It does connect to rabbitmq when it is run outside of docker.
Could use some feedback on this.