ro crate and bagit #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding rocrate requirements currently creates a zip from the rocrate object but downloads same file as before fields not yet handled correctly
…ate-metadata # Conflicts: # backend/app/routers/datasets.py
max-zilla
approved these changes
Sep 1, 2022
| shutil.rmtree(current_temp_dir) | ||
| except Exception as e: | ||
| print("could not delete file") | ||
| print(e) |
Contributor
There was a problem hiding this comment.
you can use logger for this (see keycloak.py as example)
Contributor
|
I fixed one bug during testing with empty datasets - if you dont have any files, it would skip creating one of the manifest files and fail. After that, it all looked good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ro-crate metadata as well as bagit files.
Currently a metadata file is written for a file only if that file has metadata attached.
I think that the bagit stuff is implemented right, but could use some feedback on the ro-crate stuff.