Fixed the props for search component #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Toggling Advanced switch caused page to break * Debug logs showed that the properties were not valid, updated code to reflect the same
longshuicy
requested changes
Apr 19, 2023
…ic search results * Elastic search results sometimes contains <mark> tags, which should be removed before being rendered on the frontend * Not very clear on when exactly such tags are present, so for now I have added a try-catch function that removes the HTML tags if it is present * Otherwise returns the original string
longshuicy
approved these changes
Apr 21, 2023
arunapa
added a commit
that referenced
this pull request
Apr 27, 2023
* Fixed the props for search component * Toggling Advanced switch caused page to break * Debug logs showed that the properties were not valid, updated code to reflect the same * Added try-catch function to handle inconsistent HTML content in elastic search results * Elastic search results sometimes contains <mark> tags, which should be removed before being rendered on the frontend * Not very clear on when exactly such tags are present, so for now I have added a try-catch function that removes the HTML tags if it is present * Otherwise returns the original string --------- Co-authored-by: Chen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggling Advanced switch caused page to break
Debug logs showed that the elastic search result string was not being rendered correctly as the properties were not valid, updated code to reflect the same