403 implement role change on shared tab #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group modal does not work (group role is not changed)
…ut worked, will look into this further
Contributor
Author
|
Question. Right now when I change the role for either a user or a group, the page does not refresh and it still shows the old role. Is there a way to get the dataset page to refresh but to have the the sharing tab selected after the action completes? |
max-zilla
approved these changes
Apr 13, 2023
| for u in group.users: | ||
| auth_db.user_ids.remove(u.user.email) | ||
| if u.user.email in auth_db.user_ids: | ||
| auth_db.user_ids.remove(u.user.email) |
Contributor
There was a problem hiding this comment.
this can probably stay for now, but it really indicates an issue with the group/user auth maintenance as there is a mismatch between what users are in the group and what users have permission in the auth record. not sure if you encountered this from just old records from db or a leaky endpoint somewhere however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll open this as a draft. Right now there are some things that still need fixing:
Feel free to check it out and list any other problems that come up or design/UI issues.