Skip to content

Conversation

@longshuicy
Copy link
Member

Now searching when typing; when hit enter or the "search" icon, it will also search the current word. When erase or empty string, list default listeners.

To test you can watch the network tab:
image

@longshuicy longshuicy linked an issue Apr 6, 2023 that may be closed by this pull request
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all seems to work. Marking approved.

@longshuicy longshuicy merged commit ab6cade into main Apr 11, 2023
@max-zilla max-zilla deleted the 417-search-listener-improper-use-of-onkeydown branch July 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search listener improper use of onKeyDown

3 participants