Skip to content

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Apr 6, 2023

In this PR those are the main things covered:

Backend

  1. modify the search endpoint to search for both name and description
  2. add "editor/viewer" role option when add member
  3. PUT endpoint to assign editor/viewer to member
  4. Minor bugfixes related to group

Frontend

  1. Prettify the groups component to use table
  2. Search interface for searching groups
  3. Delete group
  4. Assign editor/viewer role to group member
  5. Authwrapper to properly hide/show delete, add button based on ownership

Some of the screenshots:
image

image

image

image

@longshuicy longshuicy requested review from arunapa and lmarini April 6, 2023 13:54
@longshuicy longshuicy requested a review from tcnichol April 6, 2023 13:54
@longshuicy longshuicy linked an issue Apr 6, 2023 that may be closed by this pull request
@longshuicy longshuicy changed the title WIP: 406 group management UI improvements 406 group management UI improvements Apr 6, 2023
@longshuicy longshuicy marked this pull request as ready for review April 6, 2023 17:53
@longshuicy longshuicy requested a review from max-zilla as a code owner April 6, 2023 17:53
for u in group.users:
if u.user.email == current_user:
if u.editor and self.role == RoleType.EDITOR:
if u.editor or self.role == RoleType.EDITOR:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm misunderstanding, I don't think this should be changed. self.role is the role you are requiring in the endpoint, so this would mean even if the user u is not an editor, if your permission requires editor this would return true for any user in the group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see i misunderstood the self.role part. Sorry about that.
Will revert it

@longshuicy longshuicy requested a review from max-zilla April 6, 2023 19:20
@max-zilla max-zilla merged commit 708aa18 into main Apr 7, 2023
@max-zilla max-zilla deleted the 406-group-management-ui-improvements branch April 7, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group management UI improvements

3 participants