-
Notifications
You must be signed in to change notification settings - Fork 6
406 group management UI improvements #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| for u in group.users: | ||
| if u.user.email == current_user: | ||
| if u.editor and self.role == RoleType.EDITOR: | ||
| if u.editor or self.role == RoleType.EDITOR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misunderstanding, I don't think this should be changed. self.role is the role you are requiring in the endpoint, so this would mean even if the user u is not an editor, if your permission requires editor this would return true for any user in the group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see i misunderstood the self.role part. Sorry about that.
Will revert it
In this PR those are the main things covered:
Backend
Frontend
Some of the screenshots:
