401 group management UI continue #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-zilla
approved these changes
Mar 31, 2023
Contributor
max-zilla
left a comment
max-zilla
left a comment
There was a problem hiding this comment.
looks good and functions as expected. will make a follow-up task for a couple small improvements: 1) Add Member button is hidden if you are logged in as a Member without Editor permissions, but the delete buttons are visible. (Clicking them returns a 403 as it should). 2) Currently you can only add Members, we need a way to add Editors or change between Editor/Member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and delete user implemented