Skip to content

matching response type with actual dependency returns #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-zilla merged 2 commits into from
Mar 15, 2023
Merged

matching response type with actual dependency returns #390

max-zilla merged 2 commits into from
Mar 15, 2023

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Mar 14, 2023

Here is a quick fix

@longshuicy longshuicy requested a review from tcnichol March 14, 2023 21:22
@longshuicy longshuicy marked this pull request as ready for review March 14, 2023 21:22
@longshuicy longshuicy requested a review from max-zilla as a code owner March 14, 2023 21:22
@longshuicy
Copy link
Member Author

longshuicy commented Mar 14, 2023

I'm wondering if the GET /dataset/{dataset_id}/role need to be changed similarly. Right now it's returning the whole authorization mongo object. But this endpoint is used in the test and other places... hesitant to make this change

tcnichol
tcnichol approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Approving so can be merged in.

@max-zilla max-zilla merged commit 8a74aa7 into main Mar 15, 2023
@max-zilla max-zilla deleted the fix-mismatch-role-response-model branch March 15, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-zilla max-zilla max-zilla approved these changes

@tcnichol tcnichol tcnichol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longshuicy @max-zilla @tcnichol