Skip to content

Conversation

@max-zilla
Copy link
Contributor

@max-zilla max-zilla commented Mar 8, 2023

PR touches a few things:

  • add GroupAuthorization dependency that enforces group members/editors/owners
  • use Provenance in groups model
  • improvements to several auth/groups endpoints (some were not functioning properly)
  • new endpoints for setting user/group roles on a dataset
  • new endpoints for adding/removing user from a group
  • create test utils file with some shared JSON - need to continue to leverage

@max-zilla max-zilla marked this pull request as ready for review March 13, 2023 15:16


@router.post("/{group_id}", response_model=GroupOut)
@router.put("", response_model=GroupOut)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you leave the group_id out of the path parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no that was not intentionally removed, fixed thanks

Copy link
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created several groups. One user shared datasets only by group. The correct users can view/edit etc datasets and only the group members with roles 'editor' were able to add new group users. Everything seems to work here so marking approved.

@max-zilla max-zilla merged commit 99209d4 into main Mar 15, 2023
@max-zilla max-zilla deleted the group-management branch March 15, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants