-
Notifications
You must be signed in to change notification settings - Fork 6
Group management #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group management #388
Conversation
backend/app/routers/groups.py
Outdated
|
|
||
|
|
||
| @router.post("/{group_id}", response_model=GroupOut) | ||
| @router.put("", response_model=GroupOut) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you leave the group_id out of the path parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no that was not intentionally removed, fixed thanks
tcnichol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created several groups. One user shared datasets only by group. The correct users can view/edit etc datasets and only the group members with roles 'editor' were able to add new group users. Everything seems to work here so marking approved.
PR touches a few things: