add MetadataAuthorization dependency #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added for everything except file metadata file metadata will wait until after adding auth to file endpoints pull request merged
max-zilla
requested changes
Mar 8, 2023
| user=Depends(get_current_user), | ||
| db: MongoClient = Depends(dependencies.get_db), | ||
| es: Elasticsearch = Depends(dependencies.get_elasticsearchclient), | ||
| allow: bool = Depends(DatasetAuthorization("editor")), |
Contributor
There was a problem hiding this comment.
These should be MetadataAuthorization I think?
backend/app/routers/datasets.py
Outdated
| from app import dependencies | ||
| from app import keycloak_auth | ||
| from app.deps.authorization_deps import Authorization | ||
| from app.deps.authorization_deps import Authorization, DatasetAuthorization |
Contributor
There was a problem hiding this comment.
this can be removed (covered in other PR)
# Conflicts: # backend/app/deps/authorization_deps.py
dataset_out needed instead of dataset
max-zilla
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MetadataAuth dependency we can use if metadata_id is available in a route, and implements it on several metadata routes.
Also implemented for some dataset metadata routes.
Files will wait until this pull request merged:
#385