Skip to content

Conversation

@arunapa
Copy link
Contributor

@arunapa arunapa commented Mar 3, 2023

Completed Note: PR to be updated with code to explicitly redirect users to 404 page when they request a resource that cannot be found

  • tested by providing an incorrect file url, verified redirects to page not found

Screen Shot 2023-03-03 at 10 56 31 AM

@arunapa arunapa requested a review from longshuicy as a code owner March 3, 2023 16:57
@arunapa arunapa linked an issue Mar 3, 2023 that may be closed by this pull request
@arunapa arunapa self-assigned this Mar 3, 2023
@arunapa arunapa added enhancement New feature or request frontend Frontend specific (react) labels Mar 3, 2023
arunapa added 3 commits March 3, 2023 12:19
…an API throws 404

* tested by providing an incorrect file url, verified redirects to page not found
@arunapa arunapa requested a review from max-zilla as a code owner March 3, 2023 19:56
@arunapa arunapa requested a review from lmarini March 3, 2023 19:57
@longshuicy
Copy link
Member

hm actually i can't trigger this 404. whenever I gave a wrong URL, i get 500 error. E.g.

role = AuthorizationDB.from_mongo(authorization).role
AttributeError: 'NoneType' object has no attribute 'role'

@longshuicy
Copy link
Member

To test:

  1. go to a non-exist routes for example /datasets or /files or /something random
  2. edit file id in the URL but you have to match digits to make it a valid objectID

@longshuicy longshuicy merged commit fe5eccd into main Mar 6, 2023
@max-zilla max-zilla deleted the 207-error-page-for-when-a-resource-is-not-found branch July 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Frontend specific (react)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Error page for when a resource is not found

3 participants