348 metadata value not visible on UI #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem was contents was used instead of content fieldName was also object and not key, so using fieldName.name in place to get actual metadata value
ddey2
requested changes
Mar 2, 2023
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
I tried and got Bad request error. No more info on backend. I deleted all the volumes and restarted docker containers, so it shouldn't have nay issue with db as well.
adding metadata shows right value error on edit metadata
Contributor
Author
|
The error should be fixed now. |
longshuicy
approved these changes
Mar 6, 2023
max-zilla
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should now be fixed for all types. I created metadata definitions that are text input and date, and added the Unit metadata definition to test a dropdown.
Part of the problem was that 'contents' was used in place of 'content' in a few places so now it's always content for all metadata type. Also fieldName is an object, so using fieldName.name for the key for content[fieldName.name] to get actual metadata value. Metadata can now be created, value shown is right, and the updates work.