Add File authorization framework #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnichol
approved these changes
Feb 28, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
These look good. I'll mark approved.
longshuicy
reviewed
Feb 28, 2023
backend/app/models/authorization.py
Outdated
| class AuthorizationFile(BaseModel): | ||
| # TODO: This should be PyObjectId = Field(default_factory=PyObjectId). Need to figure out why can't create instance | ||
| # in `routers.authorization.get_dataset_role()`. | ||
| file_id: str |
Member
There was a problem hiding this comment.
I saw your todos.. could you make it ObjectID?
ddey2
approved these changes
Feb 28, 2023
| authorization = await db["authorization"].find_one( | ||
| { | ||
| "dataset_id": file_out.dataset_id, | ||
| "user_id": current_user, |
Member
There was a problem hiding this comment.
This will work for now. Once we merge my pR, it won't work as we ll have a list of user_ids. I am thinking how to handle that.
Everything else looks okay.
Member
There was a problem hiding this comment.
Yes, I have used ObjectId for user_id as well.
longshuicy
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to dataset, but inherits file role from the file's parent dataset.