Skip to content

Adding download button on UI to download correct verison file #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
longshuicy merged 3 commits into from
Feb 17, 2023
Merged

Adding download button on UI to download correct verison file #334

longshuicy merged 3 commits into from
Feb 17, 2023

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented Feb 16, 2023

No description provided.

@ddey2 ddey2 added the frontend Frontend specific (react) label Feb 16, 2023
@ddey2 ddey2 added this to the Sprint Feb 16 2023 milestone Feb 16, 2023
@ddey2 ddey2 linked an issue Feb 16, 2023 that may be closed by this pull request
Download older version of a file #303
Closed
ddey2
ddey2 commented Feb 16, 2023
View reviewed changes
frontend/src/openapi/v2/models/FileVersion.ts Outdated
export type FileVersion = {
id?: string;
file_id: string;
file_name: string;
Copy link
Member Author

@ddey2 ddey2 Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to download the file by it's file name. Hence, I added the field here but looks like it's not getting populated. @longshuicy Please take a look

Copy link
Member

@longshuicy longshuicy Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't directly modify anything in the openapi because that's auto generated by the backend.
If you would need that as an input, you need to modify the backend logic and then reran npm run codegen:v2:dev

Copy link
Member

@longshuicy longshuicy Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah i see what you are doing. You just need the filename to be passed in to the function? So probably no need to change the backend design. You can see what I did to make it work in this Diff: 5afb3cc

Copy link
Member Author

@ddey2 ddey2 Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a another way of passing that filename. Thanks for showing that. :)

@ddey2
Copy link
Member Author

ddey2 commented Feb 16, 2023

@longshuicy Also take a look at the download button. I am not an expert in UI, it may not look so fancy. :D

@ddey2 ddey2 requested a review from lmarini February 16, 2023 22:27
@longshuicy longshuicy merged commit da33baa into main Feb 17, 2023
@longshuicy longshuicy self-assigned this Feb 17, 2023
longshuicy added a commit that referenced this pull request Feb 20, 2023
@ddey2 @longshuicy
Adding download button on UI to download correct verison file (#334)
f164117 
* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>
max-zilla pushed a commit that referenced this pull request Feb 28, 2023
@arunapa @longshuicy
@ddey2 @tcnichol
UI for displaying logs on extractors (#317)
05311b7 
* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>
longshuicy added a commit that referenced this pull request Feb 28, 2023
@arunapa @longshuicy
@ddey2 @tcnichol
UI for displaying logs on extractors (#317)
fc856be 
* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>
longshuicy added a commit that referenced this pull request Feb 28, 2023
@max-zilla @arunapa
@longshuicy @ddey2 @tcnichol
Properly interpret extractor statuses (#356)
0ef3fae 
* various fixes to message listener

* black formatting

* Added new component for file actions (#352)

* Added new component for file actions

* Tested file download and file delete from File page

* Verified after deleting file, page navigates back to main dataset page

* Fixed version-not-updating error

* Updated onSave sequence to first synchronously update the file and then subsequently call listVersions API to display on the frontend

* Fixed lint issues by running eslint

* UI for displaying logs on extractors (#317)

* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>

* Millisecond (#360)

* it's seconds

* add more icons

* default to open tab

---------

Co-authored-by: Aruna Parameswaran <[email protected]>
Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>
longshuicy added a commit that referenced this pull request Mar 2, 2023
@arunapa @longshuicy
@ddey2 @tcnichol
UI for displaying logs on extractors (#317)
cfbbb76 
* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>
longshuicy added a commit that referenced this pull request Mar 2, 2023
@max-zilla @arunapa
@longshuicy @ddey2 @tcnichol
Properly interpret extractor statuses (#356)
e504354 
* various fixes to message listener

* black formatting

* Added new component for file actions (#352)

* Added new component for file actions

* Tested file download and file delete from File page

* Verified after deleting file, page navigates back to main dataset page

* Fixed version-not-updating error

* Updated onSave sequence to first synchronously update the file and then subsequently call listVersions API to display on the frontend

* Fixed lint issues by running eslint

* UI for displaying logs on extractors (#317)

* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>

* Millisecond (#360)

* it's seconds

* add more icons

* default to open tab

---------

Co-authored-by: Aruna Parameswaran <[email protected]>
Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>
max-zilla added a commit that referenced this pull request Mar 6, 2023
@ddey2 @arunapa
@longshuicy @tcnichol @max-zilla
Added group_id to authorization (#354)
d560536 
* Added group_id to authorization

* Added list of group_ids instead of one group_id per entry

* Addressing comments

* fixing lint failure

* Added new component for file actions (#352)

* Added new component for file actions

* Tested file download and file delete from File page

* Verified after deleting file, page navigates back to main dataset page

* Fixed version-not-updating error

* Updated onSave sequence to first synchronously update the file and then subsequently call listVersions API to display on the frontend

* Fixed lint issues by running eslint

* UI for displaying logs on extractors (#317)

* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>

* Properly interpret extractor statuses (#356)

* various fixes to message listener

* black formatting

* Added new component for file actions (#352)

* Added new component for file actions

* Tested file download and file delete from File page

* Verified after deleting file, page navigates back to main dataset page

* Fixed version-not-updating error

* Updated onSave sequence to first synchronously update the file and then subsequently call listVersions API to display on the frontend

* Fixed lint issues by running eslint

* UI for displaying logs on extractors (#317)

* Static UI for displaying logs on extractors

* Created 2 React custom components:
* ExtractorStatus -- UI table to display summary of job/progress so far
* ExtractorLogs -- terminal-like UI to display logs in real-time as they are being fetched

* [WIP] Enable extractor job id retrieval from backend

* Updated redux store value when job id is returned

* Added actions for job update, job summary API endpoints

* [WIP DO NOT MERGE] Testing frontend functionality with dynamic log rendering

* Updated API endpoints, return payload, reducers and actions (#330)

* Updated API endpoints, return payload, reducers and actions for the extractor jobs

* Tested API calls to fetchJobSummary, fetchJobUpdates from frontend, able to receive extractor job data

* Tested submit job process flow, able to retrieve extractor job id from the backend

* Removed redundant code

---------

Co-authored-by: Chen Wang <[email protected]>

* Integrated UI with backend

* Tested with sample extractor logs, able to view both extractor status and summary from the UI

* Removed hardcoding of job id

* Fixed indentation

* Adding download button on UI to download correct verison file (#334)

* Adding download button on UI to download correct verison file

* fix filename issue

* Update FileVersion.ts

---------

Co-authored-by: Chen Wang <[email protected]>

* fix member typing (#336)

* fix member typing

* adjust the test so it can pass

* fixing error of blank page on submit file to extractor (#338)

files.py - renaming resubmit method
codegen
fixing error in listeners.py

* Modified extractor job summary duration calculation

* Moving fetchJobSummary, fetchJobSummary API calls to ExtractorStatus component to fix interval issue

---------

Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>

* Millisecond (#360)

* it's seconds

* add more icons

* default to open tab

---------

Co-authored-by: Aruna Parameswaran <[email protected]>
Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Dipannita <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>

* Context matches v1 type. (#328)

* context is now changed to list union of AnyUrl or dict. This should make v2 compatible with some extractors from extractors-core which dynamically build the context.

* formatting
fix test

* formatting

* still getting pytest errors
changed context from optional[list] to list with default value empty, but still is not fixing the issues.

* should fix the tests

* formatting

* getting rid of class 'context element' not needed

* getting rid of class 'context element' not needed

* removing console log

---------

Co-authored-by: Chen Wang <[email protected]>

* Mongo views (#353)

* add a readme

* add listener job update view

* temp

* add init

* add to production docker-compose as well

* 343 list resources that user has access (#355)

* add logic to filter user

* add filters to file

* list files working too

* add same filter for folder

* include executions

* exempt the current resource owner

* add test database

* rewrite createView part

* rewrite init script but it's still not working yet

* fix typo

* fix linting

* Replaced EmbeddedSearch with custom search box component to fix session refresh issue (#365)

* Tested dataset search by clicking button and pressing enter, able to view search results

* match user_ids which is a list now (#368)

* update to lookup query

* update authorization_deps queries

* simplify group logic in auth check

* formatting

* Formatting

---------

Co-authored-by: Aruna Parameswaran <[email protected]>
Co-authored-by: Chen Wang <[email protected]>
Co-authored-by: Todd Nicholson <[email protected]>
Co-authored-by: Max Burnette <[email protected]>
@max-zilla max-zilla deleted the 303-download-older-version-of-a-file branch July 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longshuicy longshuicy longshuicy approved these changes

@max-zilla max-zilla Awaiting requested review from max-zilla max-zilla is a code owner

@lmarini lmarini Awaiting requested review from lmarini

Assignees

@longshuicy longshuicy

Labels

frontend Frontend specific (react)

Projects

Clowder v2 Sprints
Status: Done

Milestone

Sprint Feb 16 2023

Development

Successfully merging this pull request may close these issues.

Download older version of a file

3 participants

@ddey2 @longshuicy