Test for v1 extractor triggering #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddey2
requested changes
Feb 17, 2023
Member
ddey2
left a comment
ddey2
left a comment
There was a problem hiding this comment.
Pytest failing
your new test case in test_extractor is failing due to the below
await db["config"].insert_one(config_entry.to_mongo())
E TypeError: object InsertOneResult can't be used in 'await' expression
ddey2
approved these changes
Feb 20, 2023
…wder-framework/clowder2 into improve-v1-extractor-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple endpoints to feeds router, add a test for full cycle of triggering a job on a text file based on a v1 extractor.