update file content model #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@longshuicy I checked this one and it fixes the bug. Could someone review this and get it merged in? |
Contributor
|
Ran into an issue: When I try to submit a file to an extractor, I get the blank page again. Will get a bit and post more comments. |
adding back extract method in file service
Contributor
|
@longshuicy |
Member
Author
Looks good to me. I can't approve cuz it's my branch :-p. But you can approve |
max-zilla
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the content type is not a simple string instead an object that has two fields.
Update all the codegen models as well to reflect that.
To test:
Just open any datasets that has file in it.