Skip to content

Conversation

@lmarini
Copy link
Member

@lmarini lmarini commented Jan 23, 2023

Use config variables to setup RabbitMQ client. Were being hardcoded to localhost/guest/guest. Closes #284.

@lmarini lmarini added this to the Feb02_23 milestone Jan 23, 2023
@lmarini lmarini requested a review from tcnichol January 23, 2023 20:44
@lmarini lmarini requested a review from max-zilla as a code owner January 23, 2023 20:44
@lmarini lmarini linked an issue Jan 23, 2023 that may be closed by this pull request
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@max-zilla max-zilla merged commit 11c3dfe into main Jan 25, 2023
@max-zilla max-zilla deleted the 284-rabbitmq-client-configs-should-come-from-settings branch July 20, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rabbitmq client configs should come from settings

4 participants