Metdata version updated with metadata update

[ddey2]

1. Metadata version updated in mogodb with every metadata update
2. Show latest available metadata if metadata with specific file version is not available

[tcnichol]

I think doing the black formatting should fix the build error, then I can mark this one approved.

[ddey2]

I think doing the black formatting should fix the build error, then I can mark this one approved.

No idea why it's failing for a file where I haven't made any changes. However, still trying to format the file.

[longshuicy]

Sorry for not understanding the context, do you mean that if metadata has been changed, the file version need to be automatically bumped up? If so could you point me to the part that file_version has been updated?

[ddey2]

Sorry for not understanding the context, do you mean that if metadata has been changed, the file version need to be automatically bumped up? If so could you point me to the part that file_version has been updated?

There is 2 parts to this PR:

1. I enabled the 'all_version' from UI end so that it captures the file version whenever there is a request to update metadata.
2. We want to update the version in 'metadata' table in mongodb, current scenario we weren't updating the version. The reason we want to update it - If a file is updated, we first want to fetch metadata associated with that specific version, if it's not available, we want to show the latest version metadata.

I hope that answers your question. Lmk if you have any more.

[ddey2]

@longshuicy I enabled this here to send the version with the request to update metadata

[ddey2]

replace_metadata is the function which is already taking care of updating resource object etc.

If there is no specific version of metadata is available in mongodb, we want to update the version, hence called 'replace_metadata'

[lmarini]

@ddey2 can you resolve conflicts? I am not seeing the black check. Does it only run it if there is no conflict?

[tcnichol]

I added a file and added metadata. I updated the file, and when i changed the metadata it updated the version to v2. Is this the expected behavior? Or should the file v1 metadata still be saved in the db?

[ddey2]

I added a file and added metadata. I updated the file, and when i changed the metadata it updated the version to v2. Is this the expected behavior? Or should the file v1 metadata still be saved in the db?

This should be the expected behavior for now (as per our discussion). We plan to keep all the metadata versions, but that's for future. I have created an issue for that #277

[tcnichol]

Tested and this work. Marking approved.

[max-zilla]

I think the resource_id and version filters are unnecessary here since the _id of the metadata should be unique.

[ddey2]

It's necessary because I need to find out if metadata with the specific file id and version id exists. If it does, we can simple update the metadata here in this method, else I need to call 'replace_file_metadata' where it creates a new object with the file id and version. I could have updated the current method but chose to re-use what we already have.