Skip to content

Conversation

@tcnichol
Copy link
Contributor

Files uploaded now have the size in bytes stored as well as the content type. Visible on front end.

Not sure if the bytes are readable, many need to change to more readable format.

tcnichol added 2 commits June 22, 2022 11:16
added fields content_type and bytes to file object
bytes
content_type
@tcnichol tcnichol linked an issue Jun 22, 2022 that may be closed by this pull request
@max-zilla
Copy link
Contributor

This should be expanded to include bytes and content type in file version as well, I think. If someone replaces file with something else then reverts to old version, we need to remember what those values are on the file versions stored in MongoDB as well, not just current file object. You can see how version_num is handled in a somewhat similar fashion

@tcnichol
Copy link
Contributor Author

This should be expanded to include bytes and content type in file version as well, I think. If someone replaces file with something else then reverts to old version, we need to remember what those values are on the file versions stored in MongoDB as well, not just current file object. You can see how version_num is handled in a somewhat similar fashion

Max, I fixed this and added those fields to file version.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a followup issue #50

@lmarini lmarini merged commit e5df961 into main Jul 18, 2022
@lmarini lmarini deleted the 24-store-file-type-size-in-mongodb branch July 18, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

store file type size in mongodb

5 participants