Extractor registration fixes #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed collections, fixed exchange declaration, made host a config, a few other small things
tcnichol
approved these changes
Dec 16, 2022
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Tested. Extractors register and the extractor info is now working properly.
I'll wait until this is merged in, then update the dockerize heartbeat pull request with these changes.
is optional[dict] instead of list[dict]
…xtractor-register-fixes # Conflicts: # backend/app/rabbitmq/heartbeat_listener_sync.py
is optional[dict] instead of list[dict]
lmarini
approved these changes
Dec 19, 2022
| connection = pika.BlockingConnection(parameters) | ||
| channel = connection.channel() | ||
| """ | ||
| channel.exchange_declare( |
| db = client["clowder2"] | ||
| existing_extractor = db["listeners"].find_one({"name": extractor_queue}) | ||
| extractor_parameters = extractor_info["parameters"]["schema"] | ||
| extractor_info["parameters"] = extractor_parameters |
Member
There was a problem hiding this comment.
How come we are reassigning parameters.schema to parameters in these two lines?
Contributor
There was a problem hiding this comment.
this was a mistake. I took these lines out.
Contributor
|
Fixed how this one registers the extractor parameters. Parameters was a List[dict] changed it to be a dict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional cleanup as well: