Added dynamic context field w/ Autocomplete #244
Conversation
|
I got an edge case error: when i try to delete the last character of context this page errored out. If you watched console, it's complaining about autocomplete can't accept empty value and still cast it to lowercase. I'm suspecting the "freesolo" option need some condition. |
Thank you for catching this bug! I checked the documentation and after debugging, it looks like implementing both "onInputChange" and "onChange" was causing issues. When I tried reproducing the autocomplete input, onInputChange event registered the new value as "" while onChange modified it to null, which is likely what the error was reporting. I doubled checked the MUI API documentation and I think implementing onInputChange alone is sufficient. |
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Good finding about that onInputChange. It's working now. Approving!
lmarini
left a comment
lmarini
left a comment
There was a problem hiding this comment.
Can we rename to Metadata context name to Term and Context URL to IRI?
See get_current_username for more info.
Not on this PR, but in the future what if we moved the term mapping to each of the metadata entry. Currently I can create mappings in the context that don't match what is in the metadata definition. Ideally the Term will be the same used in the JSON for the metadata entry.
Gotcha. I've renamed the fields both in my code and in the UI. Should we create an issue in the backlog for the future item?
|
|
Yes, please. Thank you!
From: Aruna Parameswaran ***@***.***>
Date: Friday, December 16, 2022 at 11:23 AM
To: clowder-framework/clowder2 ***@***.***>
Cc: Marini, Luigi ***@***.***>, Review requested ***@***.***>
Subject: Re: [clowder-framework/clowder2] Added dynamic context field w/ Autocomplete (PR #244)
Can we rename to Metadata context name to Term and Context URL to IRI?
See get_current_username<https://urldefense.com/v3/__https:/w3c.github.io/json-ld-syntax/*the-context__;Iw!!DZ3fjg!_XsLt4l3vgNW80Yo0nPSFfLj7TTfok9HaZNLGhajbUMkdFSSGcnO7QjJZwpDHJ3ISjYuIKqfaakFPIXA61fOaa83Og$> for more info.
Not on this PR, but in the future what if we moved the term mapping to each of the metadata entry. Currently I can create mappings in the context that don't match what is in the metadata definition. Ideally the Term will be the same used in the JSON for the metadata entry.
Gotcha. I've renamed the fields both in my code and in the UI.
Should we create an issue in the backlog for the future item?
[Screen Shot 2022-12-16 at 11 23 01 AM]<https://urldefense.com/v3/__https:/user-images.githubusercontent.com/28983148/208153910-4b8db427-cc1d-4728-b2ab-38f0c081db8e.png__;!!DZ3fjg!_XsLt4l3vgNW80Yo0nPSFfLj7TTfok9HaZNLGhajbUMkdFSSGcnO7QjJZwpDHJ3ISjYuIKqfaakFPIXA61fqH3-IFQ$>
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/clowder-framework/clowder2/pull/244*issuecomment-1355260333__;Iw!!DZ3fjg!_XsLt4l3vgNW80Yo0nPSFfLj7TTfok9HaZNLGhajbUMkdFSSGcnO7QjJZwpDHJ3ISjYuIKqfaakFPIXA61e41CppXQ$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAESNLIRZJ6CHZLB5QIJCQDWNSQRVANCNFSM6AAAAAAS72WCTI__;!!DZ3fjg!_XsLt4l3vgNW80Yo0nPSFfLj7TTfok9HaZNLGhajbUMkdFSSGcnO7QjJZwpDHJ3ISjYuIKqfaakFPIXA61dNUhgrLQ$>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
| "DateTimePicker": "Date Time Picker", | ||
| "Select": "Dropdown" | ||
| } | ||
|
|
Added a dynamic form to fill up metadata context (refer to screenshots)
Validated: 1) form submit, 2) if context is empty, form cannot be submit, 3) JSON output displayed on the final step