deleting metadata on file/dataset deletion #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnichol
approved these changes
Dec 13, 2022
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Tested and everything seems to be working. Marking approved.
longshuicy
reviewed
Dec 15, 2022
| es_client.delete_by_query(index=index_name, query=query) | ||
| except BadRequestError as ex: | ||
| logger.error(str(ex)) | ||
|
|
Member
There was a problem hiding this comment.
Do you want to catch more errors other than badrequestError?
Maybe add another except: logger.error(str(e))?
Also not throwing this error?
Member
Author
There was a problem hiding this comment.
@lmarini Not resolved. @longshuicy We don't perform the action if the service is unavailable. In this scenario, I think BadRequestError is sufficient. I am all ears to suggestion. Lmk if you think I am missing any scenario
Do we want to throw the exception? We show a message if the Elasticsearch service is not available.
longshuicy
approved these changes
Dec 15, 2022
lmarini
approved these changes
Jan 17, 2023
lmarini
deleted the
237-deleting-datasetfile-doesnt-delete-associated-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.